Repository navigation
Add non-hook ConfigMap to akp-crd-manager so Argo CD runs its hooks - #1394
Merged
Merged
Conversation
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every template in
akp-crd-manageris a Helm hook (pre-install,pre-upgrade,pre-rollback). Argo CD maps these to sync hooks, which run only during a sync. An app made up only of hooks has nothing to compare, so Argo marks itSyncedand auto-sync never starts. As a result the crd-manager Job never runs and the CRDs it should install are missing.Seen on a fresh install:
akp-crd-manager-helloreportedSynced/Healthywithhistory: nullandresources: []. The Prometheus Operator CRDs were never created, and theaceapp's sync fails with:This PR adds a regular (non-hook) ConfigMap that holds the chart version and feature gates:
OutOfSyncon first install, so it syncs and the PreSync Job runs. A later change to the chart version or feature gates changes the ConfigMap, which triggers another sync and runs the Job again, the same way Helm'spre-upgradewould.