Repository navigation
Install Envoy Gateway CRDs before testing service-gateway in CI - #1393
Merged
Merged
Conversation
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1388,
service-gatewayalways rendersEnvoyProxy. Its CRD is installed by the voyager-gatewaycrd-managerpre-install hook, but helm maps every manifest kind before running hooks, soct installfails on the fresh test cluster:Failing run: https://github.com/appscode-cloud/installer/actions/runs/41639561493/job/125933044583
Changes:
hack/scripts/install-gateway-crds.sh: installs the vendoredcrd-managersubchart (fromcharts/service-gateway/charts/voyager-gateway-*.tgz) as a throwaway release so its hook Job creates the CRDs, then uninstalls the release.hack/scripts/ct.sh: forservice-gateway, delete CRDs, install the gateway CRDs, and runmake ctwithCT_CLEANUP=false(otherwisemake ctwipes the CRDs first).hack/scripts/test-service-gateway.sh: install the gateway CRDs first, since that CI step deletes all CRDs beforehand.CI-only fix; a plain
helm installofservice-gatewayon a cluster without the Envoy Gateway CRDs still fails.