Repository navigation
Conversation
`findLast` repositioned the matcher on the last match with
`region(start, end).lookingAt()`. Regions have opaque bounds by default,
so lookahead and lookbehind could not see the text around the match and
the second attempt failed. `"abab".lastIndexOf(Regex("a(?=b)"))` threw
"does not contain a match" and `replaceLast` left the string unchanged.
Reposition with `find(start)` instead, which searches the whole input
from the start of the last match.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
findLastinStringNodesfinds the last regex match, then repositions the matcher on it withm.region(r.start(), r.end()).lookingAt(). A region uses opaque bounds by default, so lookahead and lookbehind cannot see the text outside the old match and the second match attempt fails.findLastthen returnsfalseeven though a match exists:This affects the regex overloads of
lastIndexOf,lastIndexOfOrNull,replaceLastandreplaceLastMapped.Fix
Reposition with
m.find(r.start())instead. It resets the matcher and searches the whole input from the start of the last match, so lookaround sees the full string and the same match is found again.Test
Added a lookahead case to
lastIndexOf()and a lookbehind case toreplaceLast()in theapi/stringlanguage snippet test. Before the fix,LanguageSnippetTestsfails onapi/string.pkl(lastIndexOfthrows andreplaceLastreturns the string unchanged). After the fix it passes, and./gradlew :pkl-core:spotlessCheckis clean.