Skip to content

[MINOR] Fix import-boundary consumer scan skipping non-consumer dependencies - #5478

Merged
tbonelee merged 1 commit into
apache:masterfrom
voidmatcha:hotfix/import-boundary-consumer-scan
Sep 13, 2026
Merged

[MINOR] Fix import-boundary consumer scan skipping non-consumer dependencies#5478
tbonelee merged 1 commit into
apache:masterfrom
voidmatcha:hotfix/import-boundary-consumer-scan

Conversation

@voidmatcha

@voidmatcha voidmatcha commented Sep 13, 2026

Copy link
Copy Markdown
Member

What is this PR for?

Fix CI failure introduced by #5469 (already merged as 788d45a). Its findReactNotebookConsumerViolations scan restricted recursion to consumers.has(target), but a consumer's own dependency (e.g. a helper file) is never itself added to consumers, so the scan stopped detecting forbidden transport imports reached through it. Reverts to the original unconditional recursion.

What type of PR is it?

Bug Fix

Todos

What is the Jira issue?

How should this be tested?

npm run test:notebook-core: the 3 previously-failing cases (helper/javascript/require-outside) now pass.

Screenshots (if appropriate)

N/A

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@tbonelee
tbonelee merged commit 5a262cd into apache:master Sep 13, 2026
43 of 46 checks passed
@tbonelee

Copy link
Copy Markdown
Contributor

Merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants