[ZEPPELIN-6517] Add E2E tests for notebook paragraph components - #5476
[ZEPPELIN-6517] Add E2E tests for notebook paragraph components#5476miinhho wants to merge 1 commit into
Conversation
e5d7dd0 to
64c0899
Compare
|
Could you rebase this onto master? |
64c0899 to
f64538b
Compare
voidmatcha
left a comment
There was a problem hiding this comment.
Nice rework, replacing shallow visibility checks with behavior-focused scenarios. A couple of things:
Must fix: The @NB-PARITY-003/004 tags got dropped, so this PR's frontend CI is failing (log). Candidate fix: https://github.com/voidmatcha/zeppelin/tree/review/pr5476-parity-check
Unrelated bug found (ZEPPELIN-6710): While verifying this test I ran into a pre-existing bug unrelated to this PR — under CI load, Monaco's word-based suggestion swallows Enter and drops a line (line threeline four). Filed a separate ticket and put up a candidate fix: https://github.com/voidmatcha/zeppelin/tree/fix/monaco-word-suggest-enter-race (11/11 on webkit+firefox). Once that lands, the flakiness here should go away too.
Minor (non-blocking): getElapsedTime() returns 'Running…' before dateStarted is set, but the two new tests only expect /^Started .+ ago\.$/, so this could be occasionally flaky on slow CI. Fix included in the review/pr5476-parity-check branch above.
What is this PR for?
This PR improves the behavior-focused E2E coverage for the notebook paragraph sub-components.
It replaces shallow visibility checks and interpreter-error fallbacks with scenarios that verify user-observable paragraph behavior:
The paragraph page object is also updated to:
settingsMenuItem()accessorWhat type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
From
zeppelin-web-angular/, run:Questions: