[Fix][Metal][WebGPU] Preserve variable bindings when resolving allocation bounds - #20337
Open
akaashrp wants to merge 2 commits into
Open
[Fix][Metal][WebGPU] Preserve variable bindings when resolving allocation bounds#20337akaashrp wants to merge 2 commits into
akaashrp wants to merge 2 commits into
Conversation
Track primitive Bind expressions in a per-function analyzer so allocation bounds remain provable after common subexpression elimination. Continue rejecting extents whose only upper bound is the integer type limit. Test chained bounded and unbounded bindings. Update the vector-ramp test to use an explicit T.let declaration required by the current TIRx parser.
Keep a per-function arithmetic analyzer and record primitive variable bindings before resolving allocation extents. This preserves finite bounds hoisted into temporary variables, including chains of bindings, for local and workgroup allocations. Cover bounded and unbounded aliases in both storage scopes and verify that resolved workgroup allocation sizes still obey the target memory limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track primitive
Bindexpressions in a per-function analyzer so allocation bounds remain provable after common subexpression elimination. Continue rejecting extents whose only upper bound is the integer type limit.