[Fix][Relax] Preserve out_dtype in matmul rewrite passes - #20331
Open
tintin1942 wants to merge 1 commit into
Open
tintin1942 wants to merge 1 commit into
tintin1942 wants to merge 1 commit into
Conversation
Forward the original MatmulAttrs::out_dtype when ExpandMatmulOfSum and ReorderTakeAfterMatmul construct replacement matmul calls. Add regression coverage for the expansion and both take-reordering paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
ExpandMatmulOfSumandReorderTakeAfterMatmuldropping an explicitly specifiedout_dtypewhen constructing replacementmatmulcalls. Withfloat16operands andout_dtype="float32", the transformed functions incorrectly returnedfloat16.The rewrite passes constructed the replacement
matmulcalls with an unspecified output dtype. This change forwards the originalMatmulAttrs::out_dtypein:ExpandMatmulOfSum.ReorderTakeAfterMatmul.Structural regression tests cover all three rewrite paths with
float16inputs and an explicitfloat32output dtype.Tests:
cmake --build build --parallel 12python -m pytest -p no:rerunfailures tests/python/relax/test_transform_expand_matmul_of_sum.py tests/python/relax/test_transform_reorder_take_after_matmul.py tests/python/relax/test_op_linear_algebra.py -q— 26 passedctest --test-dir build --output-on-failure— 137/137 passedpre-commit run --files src/relax/transform/expand_matmul_of_sum.cc src/relax/transform/reorder_take_after_matmul.cc tests/python/relax/test_transform_expand_matmul_of_sum.py tests/python/relax/test_transform_reorder_take_after_matmul.py— passedFixes #20198