Repository navigation
Conversation
Any local process could stop the standalone server with a single byte. The in-tree stop clients now send the secret the server writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone OpenEJB admin daemon (port 4200) stopped the whole server on a single unauthenticated byte. Stop requests now need a per-start random secret, written owner-only to conf/admin-shutdown.secret, or a fixed one via openejb.admin.shutdown.secret; openejb stop, RemoteServer (tomee-maven-plugin with useOpenEJB) and RemoteTestServer send it automatically. Setting openejb.admin.shutdown.secret.required=false restores the old behaviour, which should go into the release notes. TomEE distributions do not run the admin service and are not affected.