Repository navigation
Conversation
Digested passwords in tomcat-users.xml now verify against the cleartext; the stored digest is rejected and wrong passwords return INVALID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TomEEDefaultIdentityStore compared the stored tomcat-users.xml password with plain equals, so digested passwords never matched their cleartext while the digest itself authenticated. It now verifies through the CredentialHandler of the UserDatabaseRealm bound to the same resource, falls back to a constant-time plaintext comparison with a warning if no such realm exists, and returns INVALID_RESULT for a wrong password. Adds unit tests and a new arquillian-tomee-security-tests module covering digested, plaintext and realm-less setups.