Repository navigation
Conversation
Only accept supported PBKDF2 algorithms and at least 1024 iterations; malformed hashes fail verification. Set tomee.security.pbkdf2.allow-weak-parameters=true to accept legacy hashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify() took the algorithm and iteration count from the stored hash without checks, so a weak or tampered hash (e.g. 1 iteration) was accepted. Stored hashes now need a supported PBKDF2 algorithm and at least 1024 iterations, and malformed hashes return false instead of throwing. Setting tomee.security.pbkdf2.allow-weak-parameters=true restores the old behaviour with a warning, which should go into the release notes. Covered by TomEEPbkdf2PasswordHashTest.