Repository navigation
Conversation
nchammas
added
the
ai-review-requested
Member
|
(the label is still under dev .. I will likely be able to enable it this week) |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
spark-test
removed
the
ai-review-requested
HyukjinKwon
added
the
ai-review-requested
This comment was marked as outdated.
This comment was marked as outdated.
spark-test
removed
the
ai-review-requested
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade AnchorJS to v5.0.0, and update its config accordingly to maintain roughly the current production behavior.
Additionally:
global.html, which matches where we include and configure other vendored libraries.anchorsglobal frommain.js, which is no longer needed now that the config is handled outside of there.Why are the changes needed?
The current version of AnchorJS we are using is more than 11 years old. The releases since then have added more accessible heading links and more reliable fragment generation.
This upgrade will also keep the versions in sync with the main website's version of AnchorJS: apache/spark-website#700
Does this PR introduce any user-facing change?
No, documentation behavior tweaks only.
How was this patch tested?
I built and reviewed the site locally with
SKIP_API=1 bundle exec jekyll serve. Confirmed that anchors work as expected, including forh1headings.Was this patch authored or co-authored using generative AI tooling?
I wrote this with assistance from GitHub Copilot.