[core] Generate sidecars for newly written manifests - #9889
Merged
JingsongLi merged 2 commits intoSep 16, 2026
Merged
Conversation
leaves12138
marked this pull request as ready for review
September 16, 2026 10:11
JingsongLi
reviewed
Sep 16, 2026
| .withDescription("Suggested file size of a manifest file."); | ||
|
|
||
| public static final ConfigOption<Boolean> MANIFEST_SIDECAR_WRITE = | ||
| key("manifest.sidecar.write") |
Contributor
There was a problem hiding this comment.
manifest.sidecar.enabled?
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow up on #9845 and #9886 by generating sidecars for newly created Java manifests. Extracted from #9743 after rebasing that tracking PR onto current master.
manifest.sidecar.enabled, independently overridable and inheritingmanifest-sort.enabledwhen unset.bucket != -1._EXTRA_FILESonly after the sidecar closes successfully. Writer aborts and sidecar open/write/close failures clean up their own manifest/sidecar pairs, including earlier rolled outputs.ManifestIndexTestUtilsclass declaration.This PR does not introduce sidecar scan pruning, a read option, Python changes, or a format change. Those remain separate follow-ups.
Validation
Java 8: 309 tests passed; one pre-existing disabled test was skipped. Checkstyle, Spotless and micro-benchmark test compilation passed.
New tests cover unset/default/explicit write switches, no sidecar input I/O when disabled, rolling outputs, raw-copy rewrites, publication after close, abort cleanup, partitioned/unpartitioned tables, independent coverage dimensions, invalid row IDs, and failures during sidecar creation, writing and closing.