Conversation
…ppers The three wrappers did not forward listFilesIterative, so the interface default ran on the wrapper and listed each directory with listStatus instead of using the inner object-store FileIO's flat paginated listing. Forward it like apache#9071 did for RESTTokenFileIO and apache#9034 did for tryToWriteAtomic, with a mock test per wrapper. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #9862
PluginFileIO,ResolvingFileIOandCachingFileIOdo not forwardlistFilesIterative, so theFileIOinterface default runs on the wrapper and hides the inner object-store override (HadoopCompliantFileIOin s3/oss/obs/jindo).ObjectTableImplrefresh then issues D+1listStatuscalls and materializes each directory instead of one flat paginated listing.RESTTokenFileIO) and [fs] Delegate tryToWriteAtomic through FileIO wrappers #9034 (same three wrappers,tryToWriteAtomic).Tests
PluginFileIOTest#testListFilesIterativeReachesPluginOverride(also asserts the plugin classloader),ResolvingFileIOTest#testListFilesIterativeReachesResolvedOverride,CachingFileIOTest#testListFilesIterativeReachesDelegateOverride: the delegate's iterator is returned as-is andlistStatusis never called. Each fails when only its wrapper's fix is reverted.mvn -pl paimon-common clean install(JDK 11): BUILD SUCCESS, 0 failures (checkstyle, spotless, enforcer included); the four wrapper test classes 49/49.