Conversation
…s unequal
The array element check and both map value checks in ScalarOperatorGens
only read the result flag of generateEquals, which stays false when either
operand is null. Two null elements or two null map values were therefore
reported as unequal, so ARRAY [1, null] != [1, null] and MAP {1 -> null}
!= {1 -> null} in the generated RecordEqualiser, while top-level fields and
map keys already treat null == null as equal.
Add a nullSafeEquals helper and use it at the three sites so that two nulls
compare equal and a single null compares unequal.
Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #9859
ScalarOperatorGensarray element and map value checks read only thegenerateEqualsflag (falsewhen either operand is null), so[1, null]and{1 -> null}never equal themselves. AddnullSafeEqualsat the three sites, as map keys andEqualiserCodeGeneratorfields already do.generateEqualsalso feeds the SQL=three-valued path (ExprCodeGeneratorEQUALS); Paimon's only consumer,RecordEqualiser, is a boolean value-equality contract.changelog-producer.row-deduplicate=true, an unchanged[1, null]/{1 -> null}upsert emitted a-U/+Upair fromLookupChangelogMergeFunctionWrapper; now none.Tests
EqualiserCodeGeneratorTest#testArrayEqualiserTreatsNullElementsAsEqual/#testMapEqualiserTreatsNullValuesAsEqual(red pre-fix).mvn -pl paimon-codegen -DfailIfNoTests=false clean install(JDK 11): BUILD SUCCESS, 233 tests, 0 failures.