[core] Add compression extension to text format data file names - #9853
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A text file is always written through the configured codec (
AbstractTextFileWriter:44), while the reader recovers the codec from the file name alone;file.compressionis not consulted on read.DataFilePathFactory.isTextFormatlisted onlyjsonandcsv, sofile.format=textwrote zstd bytes intodata-<uuid>-0.textand read them back as UTF-8 lines — garbage rows, no exception.Format tables are unaffected (
formatTableFileCompression()returnsnonefor text); managed tables hit it with no configuration at all, sincefile.compressiondefaults tozstd.Files already written compressed under the old name stay unreadable; this changes new writes only.
Tests
DataFilePathFactoryTest#testTextFormatCarriesTheCompressionExtension. Reverting the fix:org.apache.paimon.io.*Test: 113 run, 0 failures.Written with Claude Code; verification is mine.