[core] Preserve quoted empty and null keys/values in string-to-MAP cast - #9849
Open
wangyusheng1985 wants to merge 1 commit into
Open
wangyusheng1985 wants to merge 1 commit into
wangyusheng1985 wants to merge 1 commit into
Conversation
Signed-off-by: wangyusheng1985 <wangyusheng1985@users.noreply.github.com>
wangyusheng1985
marked this pull request as ready for review
September 15, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
String-to-MAP casting split entries first and then used a regex to separate key from value, so quote state for the individual key or value was gone by the time
parseValueran.{"" -> a}lost the empty key and{k -> "null"}became a SQL NULL value.This change splits entries and then key/value with
TokenSplitter.splitRawso quotes survive, then parses each side throughTokenSplitter.splitthe same way ARRAY and ROW already do.Fixes #9782
Tests
mvn -pl paimon-common -DwildcardSuites=none -Dtest=CastExecutorTest spotless:check testpassed (46 tests). Coverage includes quoted empty keys/values, quoted vs unquoted null, escaped null, quotes around->and,, and theMAP()function form.Validation observed for this change:
mvn -pl paimon-common -DwildcardSuites=none -Dtest=CastExecutorTest spotless:check testFixes #9782