[vortex] Free the intermediate native expressions built for a scan - #9841
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The fork swapped upstream's
Cleanerfor an explicitclose()(paimon-vortex-jni/README.md), so two expressions now leak unreachable:column(name)drops theroot()it passes togetItem, andVortexRecordsReader:95drops the inlineroot()plus its projection.Both are safe to release: vortex-jni builders do not take ownership (
expression.rsmodule doc @ 0.73.0) andscan.rs:82-92clones the projection, so both are dead oncedataSource.scanreturns. ~96 bytes per predicate leaf: over 500kcolumn()calls RSS grew 52896 KB before, 5984 KB after.Tests
No regression test is possible — native allocation has no Java-visible counter. The 72 tests in
paimon-vortex-formatprove placement: every predicate leaf and read goes through both changed paths. The converter's operands and the pushed filter still leak; that needs a lifetime contract.Written with Claude Code; verification is mine.