Repository navigation
Conversation
SteNicholas
reviewed
Nov 3, 2026
Member
There was a problem hiding this comment.
@lxy-9602, I left comments concerning fragmented-selection performance and the documentation of the built-in hash index.
SteNicholas
reviewed
Nov 6, 2026
Member
There was a problem hiding this comment.
@lxy-9602, thanks for updates. I left two comments for a compilation failure after the merge from main, and repeated IN-predicate initialization for sparse fragmented selections. PTAL.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #158
Add predicate indexes for realtime append-only and deduplicate reads. Queries can use indexed key and value fields to select candidate offsets before reading and filtering rows.
realtime.index.<plugin>.columns.[disk snapshot committed end, pinned memory end)and combine candidates with the pinned deletion vector.Indexes remain in memory when segment data spills and are retained by pinned read views until released.
Tests
Added or extended coverage for:
API and Format
RealtimeIndex,RealtimeIndexReader, andRealtimeIndexFactoryinterfaces.offset_rangetoRealtimeQueryContext; callers must supply the bounds associated with the pinned memory view and selected disk snapshot.Documentation
Introduce the optional configuration:
realtime.index.hash.columns=id,payloadGenerative AI tooling
Generated-by: OpenAI Codex (GPT-6)