KAFKA-17535: Flaky testCloseNoWait in KafkaConsumerTest for Classic Consumer - #23365
Open
gabriellefu wants to merge 2 commits into
Open
KAFKA-17535: Flaky testCloseNoWait in KafkaConsumerTest for Classic Consumer#23365gabriellefu wants to merge 2 commits into
gabriellefu wants to merge 2 commits into
Conversation
gabriellefu
commented
Sep 5, 2026
gabriellefu
commented
Contributor
- Replace closeTimeoutMs with TestUtils.DEFAULT_MAX_WAIT_MS in the final future.get(...) call, since closeTimeoutMs is enforced against MockTime and can't bound a real-time wait.
- Replace the hardcoded 1000 in the two client.waitForRequests(...) calls with TestUtils.DEFAULT_MAX_WAIT_MS, since that wait is also measured in real time and 1s wasn't always enough under load.
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.