Fix aligned flush values after time deletion - #18634
Merged
Merged
Conversation
jt2594838
commented
Sep 14, 2026
| alignedWorkingListForFlush.getValueIndex(sortedRowIndex))) { | ||
| continue; | ||
| } | ||
| // Keep value pages aligned with the time page when an entire timestamp is deleted. |
Contributor
Author
There was a problem hiding this comment.
Skip time-deleted rows while encoding aligned value pages so value positions remain aligned with the time page. This fixes the reproduced flush regression where later values shifted after DELETE plus FLUSH.
jt2594838
commented
Sep 14, 2026
|
|
||
| @Test | ||
| public void testAlignedFlushKeepsValuesAlignedAfterTimeDeletion() throws IOException { | ||
| // Deleted rows must be omitted from both time and value pages, including after sorting. |
Contributor
Author
There was a problem hiding this comment.
These tests cover both aligned flush encoding paths and page/chunk boundaries, proving deleted timestamps do not shift values and column-remapping remains correct.
jt2594838
commented
Sep 14, 2026
| * effective after the affected data is flushed from the memtable. | ||
| */ | ||
| @Test | ||
| public void testDeleteFromWhereAttributeAndTimeAfterFlush() throws SQLException { |
Contributor
Author
There was a problem hiding this comment.
This integration test reproduces the case1 SQL sequence and verifies row counts and exact values before and after FLUSH, guarding the user-visible regression.
hongzhi-gao
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes aligned table data flush after deleting a timestamp. Deleted timestamps are now filtered from both time and value pages, preventing values from shifting onto later timestamps.
Adds unit coverage for standard and remapped value-column paths, plus an end-to-end table-model integration test based on case1.
Validation
MemTableFlushTaskTest: 2 new tests passedIoTDBDeletionTableIT#testDeleteFromWhereAttributeAndTimeAfterFlush: passedBUILD SUCCESS