Preserve REST view response configuration - #3959
Open
kevinjqliu wants to merge 2 commits into
Open
kevinjqliu wants to merge 2 commits into
kevinjqliu wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove the API documentation addition and keep the REST load test focused on preserving nonempty configuration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes have focused test coverage and no unresolved blocking issues.
Pull request overview
Preserves REST view response configuration in View.config across create, load, and register operations.
Changes:
- Adds optional
View.config, defaulting to an empty mapping. - Propagates REST response configuration without changing properties or equality.
- Adds unit and REST catalog coverage.
File summaries
| File | Description |
|---|---|
tests/test_view.py |
Tests configuration defaults, explicit values, and equality. |
tests/catalog/test_rest.py |
Verifies configuration across REST view operations. |
pyiceberg/view/__init__.py |
Adds View.config. |
pyiceberg/catalog/rest/__init__.py |
Preserves response configuration when constructing views. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rambleraptor
approved these changes
Sep 14, 2026
rambleraptor
left a comment
rambleraptor
left a comment
Collaborator
There was a problem hiding this comment.
Looks like the goal is just to pass it along to the View. This seems perfectly reasonable.
ebyhr
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
REST view responses already parse
config, but_response_to_viewdiscards it when constructing aView. Preserve it asView.config, following the existingTable.configpattern, across create, load, and register operations.The REST specification defines this optional string-to-string map as view-specific configuration. This change only preserves it; applying per-view authentication is outside this PR.
Are these changes tested?
Added configuration assertions for REST create/load/register responses and coverage for explicit/default
View.config, unchanged properties, and unchanged equality. All 39 focused view tests and applicable pre-commit checks, including mypy, pass. The full unit suite is blocked during collection by the missing optionalthriftdependency.Are there any user-facing changes?
View.configexposes response configuration separately from persistentView.propertiesand defaults to an empty mapping. Existing constructor calls and view equality remain unchanged.