Conversation
YuangGao
marked this pull request as ready for review
September 12, 2026 05:30
rambleraptor
approved these changes
Sep 16, 2026
rambleraptor
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks good. I spent way too much time trying to trace out the ordering (we have too many properties related variables, naming is hard)
rambleraptor
approved these changes
Sep 16, 2026
| identifier=("static-table", metadata_location), | ||
| metadata_location=metadata_location, | ||
| metadata=metadata, | ||
| io=load_file_io({**properties, **metadata.properties}, location=metadata_location), |
Collaborator
There was a problem hiding this comment.
I think this is untested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3931
Rationale for this change
Catalog._load_file_iocomputedload_file_io({**self.properties, **properties}, location)wherepropertiesismetadata.properties— table metadata outranked the catalog configuration.py-io-impl,s3.retry-strategy-impl— dotted paths passed toimportlib.import_module) and transport configuration (s3.endpoint,s3.proxy-uri,s3.signer.uri,gcs.service.host, the ADLS authorities).config< vended credentials, so remote signing and credential vending are unchanged.Are these changes tested?
test_sql.py— coversCatalog._load_file_iothroughcreate_table/load_table.test_rest.py— coversRestCatalog._load_file_io, and pins serverconfigabove the catalog.Are there any user-facing changes?