-
Notifications
You must be signed in to change notification settings - Fork 124
ci: resolve Arrow and Parquet from conda-forge on Unix legs #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abnobdoss
wants to merge
5
commits into
apache:main
Choose a base branch
from
abnobdoss:ci/add-conda-arrow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+138
−26
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9addcb4
ci: resolve Arrow and Parquet from conda-forge on Unix legs
abnobdoss 9ce8848
ci: use conda Arrow for Hive and C++ linter
abnobdoss acaa38b
ci: capture backtrace for REST Arrow test failure
abnobdoss e547ba7
ci: use conda AWS SDK alongside conda Arrow
abnobdoss ceb88b6
ci: remove temporary REST Arrow failure diagnostics
abnobdoss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: Set up conda Arrow | ||
| description: Install Arrow and Parquet from conda-forge for CMake builds. | ||
|
|
||
| inputs: | ||
| extra-packages: | ||
| description: Extra conda packages to install, space separated. | ||
| required: false | ||
| default: "" | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Set up conda | ||
| uses: conda-incubator/setup-miniconda@8ee1f361103df19b6f8c8655fd3967a8ecb162d5 # v4.0.1 | ||
| with: | ||
| miniforge-version: latest | ||
| channels: conda-forge | ||
| channel-priority: strict | ||
| activate-environment: arrow | ||
| - name: Install Arrow and Parquet | ||
| shell: bash -el {0} | ||
| env: | ||
| EXTRA_PACKAGES: ${{ inputs.extra-packages }} | ||
| run: '"${{ github.action_path }}/install-arrow.sh"' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| #!/usr/bin/env bash | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
| # Installs Arrow and Parquet into the active conda environment and exports the | ||
| # paths CMake and the test binaries need. Run from the setup-conda-arrow action. | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| toolchain="${GITHUB_WORKSPACE}/cmake_modules/IcebergThirdpartyToolchain.cmake" | ||
|
|
||
| # Keep conda Arrow in sync with the vendored build. | ||
| arrow_version=$(sed -nE 's/^set\(ICEBERG_ARROW_BUILD_VERSION "([0-9]+\.[0-9]+\.[0-9]+)"\)$/\1/p' "${toolchain}") | ||
| if [[ -z "${arrow_version}" ]]; then | ||
| echo "::error::Could not read ICEBERG_ARROW_BUILD_VERSION from ${toolchain}" | ||
| exit 1 | ||
| fi | ||
|
|
||
| packages=("libarrow==${arrow_version}" "libparquet==${arrow_version}") | ||
| if [[ -n "${EXTRA_PACKAGES:-}" ]]; then | ||
| read -r -a extra_packages <<< "${EXTRA_PACKAGES}" | ||
| packages+=("${extra_packages[@]}") | ||
| fi | ||
| mamba install -y "${packages[@]}" | ||
|
|
||
| echo "CMAKE_PREFIX_PATH=${CONDA_PREFIX}" >> "${GITHUB_ENV}" | ||
| # build_iceberg.sh reads this and fails if CMake configured vendored Arrow anyway. | ||
| echo "ICEBERG_REQUIRE_SYSTEM_ARROW=ON" >> "${GITHUB_ENV}" | ||
|
|
||
| if [[ "${RUNNER_OS}" == "macOS" ]]; then | ||
| echo "DYLD_FALLBACK_LIBRARY_PATH=${DYLD_FALLBACK_LIBRARY_PATH:+${DYLD_FALLBACK_LIBRARY_PATH}:}${CONDA_PREFIX}/lib" >> "${GITHUB_ENV}" | ||
| else | ||
| echo "LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+${LD_LIBRARY_PATH}:}${CONDA_PREFIX}/lib" >> "${GITHUB_ENV}" | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,6 +62,8 @@ jobs: | |
| - name: Install dependencies | ||
| shell: bash | ||
| run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev | ||
| - name: Set up conda Arrow | ||
| uses: ./.github/actions/setup-conda-arrow | ||
| - name: Set up sccache | ||
| uses: ./.github/actions/setup-sccache | ||
| with: | ||
|
|
@@ -94,7 +96,9 @@ jobs: | |
| env: | ||
| SCCACHE_DIR: ${{ github.workspace }}/.sccache | ||
| SCCACHE_CACHE_SIZE: "2G" | ||
| ICEBERG_EXTRA_CMAKE_ARGS: "-DICEBERG_BUILD_HIVE=ON" | ||
| # Prebuilt Arrow exports no Thrift target, so resolve the Thrift runtime | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we lose the test coverage of hive with bundled thrift? |
||
| # from conda instead of Arrow's bundled build. | ||
| ICEBERG_EXTRA_CMAKE_ARGS: "-DICEBERG_BUILD_HIVE=ON -DICEBERG_BUNDLE_THRIFT=OFF" | ||
| steps: | ||
| - name: Checkout iceberg-cpp | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
|
|
@@ -103,6 +107,12 @@ jobs: | |
| - name: Install dependencies | ||
| shell: bash | ||
| run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev | ||
| - name: Set up conda Arrow | ||
| uses: ./.github/actions/setup-conda-arrow | ||
| with: | ||
| # Thrift's public C++ headers include Boost, and libboost-devel (not | ||
| # libboost-headers) is the package carrying BoostConfig.cmake. | ||
| extra-packages: libboost-devel | ||
| - name: Restore sccache cache | ||
| uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 | ||
| with: | ||
|
|
@@ -140,6 +150,8 @@ jobs: | |
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Set up conda Arrow | ||
| uses: ./.github/actions/setup-conda-arrow | ||
| - name: Set up sccache | ||
| uses: ./.github/actions/setup-sccache | ||
| with: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this check be moved into CMake?