Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR apache#666
The previous fix in icing/mod_h2#181 does not work anymore. (cherry picked from commit ff3dd26)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
test/modules/http2/test_111_header_limit_log.pycovering the fix in #666, together with that PR's commit so the new case has something to run against. The test setsLimitRequestFields 5andLogLevel http2:info, sends one HTTP/2 request carrying 25 extra headers, and asserts thatAH10181appears in the error log exactly once. Without #666 it appears 23 times; with it, once.The guard that stopped working is worth spelling out, since #666 only says the earlier fix no longer does.
h2_stream_add_header()gated its log calls on!h2_stream_is_ready(stream), butset_error_response()now only records a status onrtmpand never setsstream->response, which is whath2_stream_is_ready()tests. While request headers are still arriving neither that nor a response bucket exists, so the guard is always false.One observation from writing the test: of the four call sites #666 touches,
AH10180already carried&& !stream->request_headers_failedand so never flooded — the change there just drops the redundantis_readyhalf. A first attempt at a reproducer aimed at that site, with oversized headers rather than too many of them, passes on trunk unchanged. The flood is at the other three sites, andAH10181is the one reachable from a plain request.🤖 Generated with Claude Code