modules/md/md_acme_acct.c (find_acct): Do not dereference a NULL md in the debug log - #764
Closed
PavlNekrasov wants to merge 1 commit into
Closed
PavlNekrasov wants to merge 1 commit into
PavlNekrasov wants to merge 1 commit into
Conversation
Problem: find_acct() accepts a candidate account when ctx->md is NULL, and dereferences ctx->md in the very next statement to log it. The two lines contradict each other, so the NULL that the condition admits crashes the logging call. Solution: Log the CA only when there is an md, keeping the NULL that the condition already allows. Signed-off-by: p.nekrasov@fobos-nt.ru Signed-off-by: sovtouch@altlinux.org
Collaborator
|
LGTM, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: DEREF_AFTER_NULL
Problem:
find_acct() accepts a candidate account when ctx->md is NULL, and dereferences ctx->md in the very next statement to log it. The two lines contradict each other, so the NULL that the condition admits crashes the logging call.
httpd/modules/md/md_acme_acct.c
Lines 283 to 287 in ba3d76a
Solution:
Log the CA only when there is an md, keeping the NULL that the condition already allows.
Signed-off-by: p.nekrasov@fobos-nt.ru
Signed-off-by: sovtouch@altlinux.org