[WIP]HIVE-29843: Avoid deleting shared database directories - #6777
Open
Gezi-lzq wants to merge 1 commit into
Open
[WIP]HIVE-29843: Avoid deleting shared database directories#6777Gezi-lzq wants to merge 1 commit into
Gezi-lzq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove recursive database-directory cleanup from failed
create_databaserollbacks and add a regression test.Issue: https://issues.apache.org/jira/browse/HIVE-29843
Why are the changes needed?
mkdirsdoes not prove exclusive directory ownership. A concurrent request that loses the metadata race can otherwise delete the directory adopted by the successful request, leaving Hive metadata and Iceberg data inconsistent.Does this PR introduce any user-facing change?
Yes. Failed
create_databaserequests no longer delete the final database directory. Empty directories may remain, but shared data is preserved.How was this patch tested?
Result: 1 test passed.