Repository navigation
[rust] Tighten down internal API visibility to pub(crate) (#377) - #665
Closed
VidyavathiGK wants to merge 1 commit into
Closed
VidyavathiGK wants to merge 1 commit into
VidyavathiGK wants to merge 1 commit into
Conversation
Audit and restrict visibility of internal types, functions, and modules to pub(crate) across crates/fluss to prevent backward-compatibility issues. - crates/fluss/src/lib.rs: hide internal io module - crates/fluss/src/rpc/: hide server_connection internals (RpcClient, ServerConnection) and all RPC request messages while preserving list_offsets::OffsetSpec - crates/fluss/src/client/: hide internal write/lookup/admin helpers, credentials, token management, bucket assigners, and connection internals - crates/fluss/src/cluster/: hide Cluster and BucketLocation types - crates/fluss/src/config.rs: make validation methods pub(crate) - crates/fluss/src/error.rs: make client error constructors pub(crate) - crates/fluss/src/metadata/: tighten all to_pb, from_pb, to_i32, and try_from_i32 conversion functions to pub(crate) - crates/fluss/src/record/: tighten arrow constants, builders, and iterators to pub(crate) while preserving public arrow conversion functions - crates/fluss/src/row/: tighten internal binary, compacted, encode, and paimon modules and decoders - crates/fluss/tests/integration/utils.rs: update readiness check to use public FlussAdmin API instead of internal connection metadata
Contributor
|
Same here, This repo is moved to https://github.com/apache/fluss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Closes #377.
Audits and restricts the visibility of internal-only structs, enums, traits, functions, and modules across
crates/flusstopub(crate)to avoid exposing internal implementation details and risking backward-compatibility breaks once released.Brief change log
mod io;.RpcClient,ServerConnection,MessengerTransport,SaslConfig).pub(crate)while preserving public APIlist_offsets::OffsetSpec.FlussAdmin,FlussConnection,TableUpsert, andTableScanpub(crate).pub(crate).RecordAccumulator,BucketAssigner,IdempotenceManager,Sender, andWriterClient.WriteResultFuturepublicly.ClusterandBucketLocationtopub(crate).to_type_idandfrom_type_idtopub(crate).validate_security,validate_scanner,validate_writer)pub(crate).table_not_exist,invalid_table,partition_not_exist, etc.)pub(crate).to_pb,from_pb) and wire enum helpers (to_i32,try_from_i32) across metadata submodules topub(crate).pub(crate)while preservingto_arrow_schema,to_arrow_type, andfrom_arrow_field.ScanRecord.rowprivate (accessed viaScanRecord::row(&self)).binary,compacted,encode, andpaimonrow modules topub(crate).tests/integration/utils.rsto use publicFlussAdmin::get_server_nodesAPI.Verifying this change
bindings/python,bindings/cpp,bindings/elixir) and examples.FlussConnection,FlussAdmin,FlussTable, scanners, writers, row getters, schemas, datatypes).