[ISSUE apache/dubbo#13862] Migrate dubbo-samples-triple-rest-openapi-generator to Spring Boot 3.2.3 - #1301
[ISSUE apache/dubbo#13862] Migrate dubbo-samples-triple-rest-openapi-generator to Spring Boot 3.2.3#1301zeng-bohan wants to merge 1 commit into
Conversation
|
Friendly bump after two weeks: this migrates the last remaining Spring Boot 2 sample in |
|
Closing this for now: I've hit the per-user open pull request limit on my account and need the slot for a higher-priority change. The branch stays available on my fork, and I'm happy to reopen this once a slot frees up. Thanks! |
|
The Up to that point the shard was green (
Could someone with write access re-run the failed job? Happy to push a trivial retrigger instead if that's easier for the workflow. |
- Bump spring-boot-starter-parent from 2.7.18 to 3.2.3, aligning the module with the dubbo-samples-triple-rest aggregate parent BOM; this was the last sample still on Spring Boot 2.x - Replace javax.annotation-api with jakarta.annotation-api and migrate the generated sources to jakarta.annotation.Generated - Enable useJakartaEe in the openapi-generator config so regenerated sources stay on the jakarta namespace - Update README system requirements to Java 17+ Tracks apache/dubbo#13862. Verified with 'mvn clean package -DskipTests' (same as CI build opts): build succeeds on Spring Boot 3.2.3 / JDK 17. Signed-off-by: zengbohan1 <310902929+zengbohan1@users.noreply.github.com>
fd73f93 to
8fa764c
Compare
|
Re-triggering CI for the While re-triggering, I also squashed the branch to a single commit: upstream |
|
Second re-trigger ( Run: https://github.com/apache/dubbo-samples/actions/runs/34936004364 (head The root cause is in the container setup, before any test of this PR's module runs — pulling the The dependency containers never started ( Two reasons this is not the migration:
Could someone with write access re-run the failed job? Thanks. |
|
Follow-up on the re-triggered CI, so nobody has to dig: the one red check is another environment flake, not the change.
The other 21 modules in that shard passed or were correctly version-skipped; this PR's module ( The same commit ( Summary on this head: the migrated module is exercised and green everywhere it runs; the two historical reds are (1) a Docker Hub 502 during compose setup and (2) a 602 s container-wait timeout in |
Migrates the last remaining Spring Boot 2 sample to Boot 3, as tracked in apache/dubbo#13862 (claim comment: apache/dubbo#13862 (comment)).
Changes
spring-boot-starter-parentfrom 2.7.18 to 3.2.3 indubbo-samples-triple-rest-openapi-generator, aligning the module with thedubbo-samples-triple-restaggregate parent BOM — this was the last sample in the repository still on Spring Boot 2.xjavax.annotation-apiwithjakarta.annotation-apiand migrate the generated sources fromjavax.annotation.Generatedtojakarta.annotation.GenerateduseJakartaEein thepom-generator.xmlopenapi-generator config (7.16.0 supports it) so future regenerations stay on the jakarta namespaceVerification
mvn clean package -DskipTestssucceeds on JDK 17 (same command as the CI build opts, which also test againstspring-boot.version:3.2.3)javaximports remain undersrc/Notes
contextLoadstest requires a running Zookeeper and is skipped by CI's-DskipTestsbuild opts, so it is not affected by this change.