[test](ivm) Remove unnecessary cloud skips from IVM suites - #67876
Open
yujun777 wants to merge 1 commit into
Open
[test](ivm) Remove unnecessary cloud skips from IVM suites#67876yujun777 wants to merge 1 commit into
yujun777 wants to merge 1 commit into
Conversation
### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: Several IVM regression suites unconditionally skipped cloud mode without a cloud-specific reason. Remove those guards so ordinary IVM, fallback-stream, column-drop, and row-binlog coverage runs in both deployment modes while retaining guards for transaction-path and plan-shape differences. ### Release note None ### Check List (For Author) - Test: No need to test (regression marker cleanup; diff check passed) - Behavior changed: No - Does this need documentation: No Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Review status: complete for head f171f9ace68ececde8c07dde338040e572e4a459 after two convergence rounds. I am requesting changes for one test-routing issue.
Critical checkpoints:
- Goal and test proof: removing the guards correctly exposes the schema-change and MTMV row-binlog suites to the normal Cloud P0 executor, and the traced Cloud paths support their assertions. However, the two fallback-stream suites remain
nonConcurrent, so the standard Cloud jobs never schedule them; two of the four hunks therefore do not provide the stated ordinary Cloud coverage. The PR also reports that the regression suites were not run, so runtime validation is still absent. - Scope and clarity: the diff is minimal and focused; it changes only four test-mode guards and no production behavior.
- Concurrency and lifecycle: there is no production locking or lifecycle change. The fallback suites intentionally use the serial group because they toggle an unscoped all-FE debug point; running them in the normal parallel pool would interfere with unrelated IVM refreshes, which is why a Cloud serial path or test/debug-point redesign is needed.
- Compatibility, parallel paths, data, and persistence: no configuration, FE/BE protocol, storage-format, EditLog, or persistence contract changes are introduced. I traced Cloud schema change, Table Stream read states and same-transaction offset commits, MTMV compute-group selection, and companion row-binlog publication; no additional Cloud/runtime defect was substantiated.
- Tests and expected results: ordered queries and existing generated outputs are consistent, setup drops objects before use, and global debug/session state is cleaned up. No builds or test executions were attempted because the review instructions prohibit them; conclusions are static-review evidence.
- Performance and observability: no applicable production impact.
- User focus: no additional focus was provided.
The inline comment covers the identical scheduling issue in both fallback-stream suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Several IVM regression suites unconditionally skipped cloud mode without a cloud-specific reason. Remove those guards so ordinary IVM, fallback-stream, column-drop, and row-binlog coverage runs in both deployment modes while retaining guards for transaction-path and plan-shape differences.
Related issue: #65418
Release note
None
Check List (For Author)