fix: ignore constant aggregate completion boundaries - #25019
Open
yashrb24 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Since #24697 is making the broader fix for this problem, we can possibly have it fixed in that PR instead of here |
yashrb24
marked this pull request as ready for review
September 7, 2026 12:08
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25019 +/- ##
==========================================
- Coverage 81.70% 81.69% -0.01%
==========================================
Files 1127 1127
Lines 416001 416081 +80
Branches 416001 416081 +80
==========================================
+ Hits 339902 339937 +35
- Misses 56125 56153 +28
- Partials 19974 19991 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
A grouping column with one fixed value never changes, so it cannot tell aggregation that an earlier group is complete.
Currently the logic uses such columns when choosing how aggregation processes its input. This can select the ordered path even when the remaining grouping columns are not ordered.
What changes are included in this PR?
What is the testing strategy for this PR?
Added tests for a grouping column fixed by a filter. The tests fail without the fix.
Are there any user-facing changes?
No query results or public APIs change. DataFusion now chooses the appropriate aggregation path for fixed grouping columns.