perf: defer nulls creation until needed in ArrowBytesViewMap - #25014
perf: defer nulls creation until needed in ArrowBytesViewMap#25014rluvaton wants to merge 1 commit into
ArrowBytesViewMap#25014Conversation
|
run benchmarks |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing avoid-holding-nulls (ff2201a) to cc29ea1 (merge-base) diff Run configurationrun benchmark clickbench_partitionedResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing avoid-holding-nulls (ff2201a) to cc29ea1 (merge-base) diff Run configurationrun benchmark tpchResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing avoid-holding-nulls (ff2201a) to cc29ea1 (merge-base) diff Run configurationrun benchmark tpcdsResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing avoid-holding-nulls (ff2201a) to cc29ea1 (merge-base) diff Run configurationrun benchmark tpchCPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing avoid-holding-nulls (ff2201a) to cc29ea1 (merge-base) diff Run configurationrun benchmark tpcdsCPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing avoid-holding-nulls (ff2201a) to cc29ea1 (merge-base) diff Run configurationrun benchmark clickbench_partitionedCPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25014 +/- ##
==========================================
- Coverage 81.70% 81.70% -0.01%
==========================================
Files 1127 1127
Lines 415654 415648 -6
Branches 415654 415648 -6
==========================================
- Hits 339614 339590 -24
- Misses 56101 56115 +14
- Partials 19939 19943 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Which issue does this PR close?
N/A
Rationale for this change
No need to hold
NullBufferBuilderand keep appending to it when we can create it once much fasterWhat changes are included in this PR?
remove
NullBufferBuilderfromArrowBytesViewMapand create when converting to stateWhat is the testing strategy for this PR?
existing tests
Are there any user-facing changes?
no