Repository navigation
Conversation
Preserve positive sub-second validation bounds in both JDBC validation paths and cover them with regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JDBC interprets a zero-second validation timeout as unlimited. A positive sub-second
Durationcurrently truncates to zero, so validation can run without the requested bound.Round positive sub-second values up to one JDBC second in both the validation-query and
Connection.isValidpaths. Preserve zero/negative values as the existing no-timeout behavior, document the conversion, add regressions for both paths, and add the DBCP-600 change entry.Jira: https://issues.apache.org/jira/browse/DBCP-600
Validation
mvn -q verifypassed locally.mvn) passed locally on this exact tree, including a fresh run before publication.Contributor checklist