Skip to content

[WIP] KVM: Support multi vlan trunk NICs - #14166

Draft
Pearl1594 wants to merge 3 commits into
mainfrom
support-multi-vlan-guestnet
Draft

Pearl1594 wants to merge 3 commits into
mainfrom
support-multi-vlan-guestnet

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Description

This PR adds support for multi-vlan trunk NICs
// TODO: details to be added

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr and others added 2 commits September 14, 2026 15:29
Adds a 4.23.0 to 24.0.0 upgrade path (squashed from sb/upgradepath-424:
engine-schema: upgrade path for 24.0.0, fix CS version, fix upgrade
unit tests for cutover, fix imports).
@github-actions

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 19.67213% with 147 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.89%. Comparing base (dc0ba1c) to head (219f9cb).

Files with missing lines Patch % Lines
...rc/main/java/com/cloud/vm/dao/NicNetworkMapVO.java 0.00% 58 Missing ⚠️
...in/java/com/cloud/vm/dao/NicNetworkMapDaoImpl.java 0.00% 32 Missing ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 0.00% 20 Missing ⚠️
...g/apache/cloudstack/api/response/HostResponse.java 0.00% 12 Missing ⚠️
...ngine/schema/src/main/java/com/cloud/vm/NicVO.java 0.00% 6 Missing ⚠️
...java/com/cloud/agent/manager/AgentManagerImpl.java 28.57% 2 Missing and 3 partials ⚠️
...org/apache/cloudstack/utils/CloudStackVersion.java 85.18% 2 Missing and 2 partials ⚠️
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java 50.00% 2 Missing and 1 partial ⚠️
...java/com/cloud/upgrade/dao/Upgrade42300to2400.java 57.14% 3 Missing ⚠️
...a/org/apache/cloudstack/veeam/api/dto/Version.java 50.00% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14166      +/-   ##
============================================
- Coverage     19.89%   19.89%   -0.01%     
- Complexity    20144    20150       +6     
============================================
  Files          6371     6374       +3     
  Lines        576829   577001     +172     
  Branches      70627    70633       +6     
============================================
+ Hits         114778   114785       +7     
- Misses       449507   449667     +160     
- Partials      12544    12549       +5     
Flag Coverage Δ
uitests 3.71% <ø> (ø)
unittests 21.16% <19.67%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
27.7% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

@github-actions

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 24.81%
Branch coverage 19.02%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants