backup: remove the powered-off precondition for all backup providers - #14094
backup: remove the powered-off precondition for all backup providers#14094weizhouapache wants to merge 1 commit into
Conversation
|
This condition check was added in the KBOSS PR (#12758). I’m not sure why it was added to the providers (excluding KBOSS). I assume this is a typo and that it should apply to KBOSS only. Please correct me if I’m wrong. @JoaoJandre @winterhazel |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14094 +/- ##
=========================================
Coverage 19.83% 19.83%
- Complexity 20026 20032 +6
=========================================
Files 6371 6371
Lines 575986 575984 -2
Branches 70526 70525 -1
=========================================
+ Hits 114235 114271 +36
+ Misses 449326 449277 -49
- Partials 12425 12436 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates the restore-volume workflow so the “VM must be powered off” precondition is enforced only for the KBOSS backup provider, allowing other providers (e.g., NAS) to restore/attach without requiring the VM to be powered off.
Changes:
- Inverts the provider guard so the power-off check applies only when the backup offering provider is KBOSS.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19167 |
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
This was my error when cherry-picking the changes to main. The original branch I was working on had #7221 applied, which introduced this check for all providers. I thought it was there for a reason for other providers, so I just added an exception for KBOSS. You can just remove the condition as a whole. It does not make sense for KBOSS. I don't think the condition makes sense for any provider actually. |
|
[SF] Trillian test result (tid-16947)
|
a23ef59 to
b366a1e
Compare
@JoaoJandre |
weizhouapache
changed the title
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19202 |
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
JoaoJandre
left a comment
JoaoJandre
left a comment
There was a problem hiding this comment.
CLGTM, did not test it.
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-16970) |
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Description
This check is not needed.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?