Skip to content

ui: filter unreachable pools on live migration with storage wizard - #14064

Merged
shwstppr merged 1 commit into
apache:4.22from
winterhazel:live-migration-ui-improvement
Sep 9, 2026
Merged

ui: filter unreachable pools on live migration with storage wizard#14064
shwstppr merged 1 commit into
apache:4.22from
winterhazel:live-migration-ui-improvement

Conversation

@winterhazel

Copy link
Copy Markdown
Member

Description

The "Migrate instance to another host" wizard lets an operator pick a destination host and, optionally, a destination
primary storage. Today the storage list is not filtered by the selected host, so it offers primary storages the host cannot reach. This filters that list down to the storages actually accessible to the selected host.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

Tested manually in a local environment by migrating an Instance between 2 hosts with distinct accessible primary storages.

@winterhazel

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@winterhazel a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.82%. Comparing base (2b3cca6) to head (ac6cef3).
⚠️ Report is 7 commits behind head on 4.22.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #14064      +/-   ##
============================================
- Coverage     17.83%   17.82%   -0.01%     
+ Complexity    16023    16022       -1     
============================================
  Files          5928     5928              
  Lines        534404   534409       +5     
  Branches      65399    65401       +2     
============================================
- Hits          95290    95284       -6     
- Misses       428296   428307      +11     
  Partials      10818    10818              
Flag Coverage Δ
uitests 3.82% <ø> (-0.01%) ⬇️
unittests 18.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/14064 (QA-JID-989)

@winterhazel winterhazel changed the title ui: filter reachable pools on live migration with storage wizard ui: filter unreachable pools on live migration with storage wizard Sep 7, 2026

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested with a mixed zone env with 2 KVM clusters (1 host each) and a VMware cluster.
Before and after results,

Image

@sudo87 sudo87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shwstppr shwstppr added this to the 4.22.2 milestone Sep 9, 2026
@shwstppr
shwstppr merged commit a9b2f33 into apache:4.22 Sep 9, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants