Skip to content

Fix infrastructure leak in template from volume creation error message #12650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erikbocks wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −2
Open

Fix infrastructure leak in template from volume creation error message #12650

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daa3813
Change in exception message displayed when creating template from volume
erikbocks Feb 15, 2026
4ac7f0c
Address copilot's review for message change
erikbocks Mar 17, 2026
0874406
Apply suggestion
erikbocks Mar 18, 2026
8fa607e
Enhance error logging for image store retrieval failure
erikbocks Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions server/src/main/java/com/cloud/template/TemplateManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ public DataStore getImageStore(String storeUuid, Long zoneId, VolumeVO volume) {
}

if (imageStore == null) {
throw new CloudRuntimeException(String.format("Cannot find an image store for zone [%s].", zoneId));
throwExceptionForImageStoreObtentionFailure(zoneId, "upload volume");
}

return imageStore;
Expand Down Expand Up @@ -1702,7 +1702,7 @@ public VirtualMachineTemplate createPrivateTemplate(CreateTemplateCmd command) t
}
DataStore store = _dataStoreMgr.getImageStoreWithFreeCapacity(zoneId);
if (store == null) {
throw new CloudRuntimeException("cannot find an image store for zone " + zoneId);
throwExceptionForImageStoreObtentionFailure(zoneId, "create template");
}
AsyncCallFuture<TemplateApiResult> future = null;

Expand Down Expand Up @@ -2479,4 +2479,9 @@ public VirtualMachineTemplate linkUserDataToTemplate(LinkUserDataToTemplateCmd c

return _tmpltDao.findById(template.getId());
}

private void throwExceptionForImageStoreObtentionFailure(Long zoneId, String operation) {
logger.error("Cannot find an image store for zone [{}] while trying to {}.", zoneId, operation);
throw new CloudRuntimeException(String.format("Failed to %s. Please contact the cloud administrator.", operation));
Comment on lines +2483 to +2485

@winterhazel winterhazel Sep 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikbocks I think we can throw a more informative CloudRuntimeException here instead, stating which zone it is (either the name or the UUID). These are automatically converted to a more generic message for non-root admin accounts.

}
}
Loading