Stabilize timer and socket unit tests - #3540
Merged
Merged
Conversation
Keep verifying that stop_and_join wakes the timer thread instead of waiting for future tasks, while allowing for CI runner scheduling delays.
Wait for every write callback before failing and releasing the socket. Stop repeated runs after the first failure and bound the initial wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
Two unit tests can fail under CI load because they rely on tight timing
assumptions. The timer test requires shutdown within 15 milliseconds, and the
socket test releases its socket after a fixed 50-millisecond delay without
ensuring that all asynchronous write callbacks have completed.
What is changed and the side effects?
Changed:
while allowing for CI runner scheduling delays.
releasing the socket.
Side effects:
delay in every shutdown-write iteration.
Check List: