Repository navigation
read the jakarta servlet temp dir in WarBasedAxisConfigurator - #1312
Merged
robertlazarski merged 1 commit intoOct 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WarBasedAxisConfigurator builds the artifactsDIR parameter from getAttribute("javax.servlet.context.tempdir"), a name left over from before the jakarta migration. jakarta containers publish the private per-webapp temp directory only as jakarta.servlet.context.tempdir (Tomcat 10.1 sets just that name in StandardContext.postWorkDirectory), so the lookup returns null and new File(null, "_axis2") resolves against the JVM working directory, or falls back to the fixed, shared ${java.io.tmpdir}/_axis2. neither location is private to the webapp. ConfigurationContext.cleanupTemp recursively deletes that directory at shutdown, and File.isDirectory/list follow a symlink, so a local user who pre-creates /tmp/_axis2 as a link gets the target emptied as the container user. JAXWSRIWSDLGenerator also writes wsgen output into a name derived from it and reads the WSDL and schemas back from there (CWE-377/CWE-59). read ServletContext.TEMPDIR so the container's own directory is used again. WarBasedAxisConfiguratorTempDirTest mocks a ServletContext that sets only the jakarta attribute: before the change it fails with artifactsDIR resolving to the relative _axis2, and after it artifactsDIR is under the container dir. mvn -Papache-release verify on axis2-kernel passes (487 tests).