Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldIncludeService in OpenApiSpecGenerator decides which services appear in openapi.json/openapi.yaml (paths and components), the openapi-mcp.json tool catalog and the mcp resources list, but it only checks ignoredServices and exposeServiceMetadata. the /services listing on both render paths (ListingAgent.processListServices, HTTPTransportReceiver) treats hiddenService as a second, separate control and drops a service when either is set. so a service deployed with hiddenService=true is absent from /services, yet an unauthenticated GET /openapi-mcp.json or /openapi.json still returns its name, every operation endpoint and the reflected request/response schemas, and the mcp bridge registers those operations as callable tools. this adds the Utils.isHiddenService check next to the exposeServiceMetadata one, so all four generator loops skip the service. the new tests in OpenApiSpecGeneratorTest and McpCatalogGeneratorTest fail without the change, and the openapi module suite (272 tests) passes with it.