LDAP plugin - #294
Draft
DanielAuerX wants to merge 6 commits into
Draft
Conversation
DanielAuerX
marked this pull request as draft
June 30, 2025 12:24
Member
|
@DanielAuerX Thank you very much for your contribution. A related issue has been mentioned before. #19 #61 |
DanielAuerX
force-pushed
the
ldap_plugin
branch
2 times, most recently
from
July 5, 2025 15:56
eb5453c to
9812413
Compare
Author
|
Hi @LinkinStars, currently i see two issues:
|
+ removed logs + using login.html + implemented ldaps: user can set a cert file for private ca
DanielAuerX
force-pushed
the
ldap_plugin
branch
from
September 13, 2026 09:07
9812413 to
0e36f1a
Compare
+ set tls.Config.ServerName in dialWithTLS so StartTLS connections (non-ldaps:// servers) actually verify. Without it every StartTLS attempt failed with "ServerName or InsecureSkipVerify must be specified". + fix extractUserInfo returning nil for the non-pointer plugin.ExternalLoginUserInfo struct, which failed to compile. + added missing go.sum and go-ldap/pacman + added readme
Author
|
Hi @LinkinStars, are you still interested in this plugin? If yes, I would continue working on it and finish the PR. |
Author
Author
|
A manual to test the plugin locally: |
Author
here the related PR in answer core for 2. |
+ replace the bare unstyled form with a centered card layout matching common auth-page conventions + fetch /answer/api/v1/siteinfo client-side to set the page title, favicon, logo, and accent color from the site's configured branding/theme, falling back to plain defaults if the request fails. + keep the RECEIVER_URL_PLACEHOLDER form action and username/password field names unchanged so ConnectorSender/ConnectorReceiver still work.
Author
Problem described in 1) is addressed in 8c931fdd8a031c88b9b5207d6f7914e308cdb354 This is how the login page would look with branding/favicon and a green primary color: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Hi, just wanted to check if there is interest in a ldap plugin such as this.
Obviously, some things that are specific to my use case have to be changed before merged, such as the login html and the email dummy solution.
included in this pr:
some ideas for future improvement: