Repository navigation
[AMORO-1121][Spark] Protect internal mixed-table properties in ALTER TABLE - #4446
Open
pallavithegod wants to merge 1 commit into
Open
pallavithegod wants to merge 1 commit into
pallavithegod wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Addresses #1121 for Spark's mixed-table catalog entry points.
Spark
ALTER TABLEcurrently forwards user property changes to mixed-table commits without restricting internal transaction, partition, and watermark bookkeeping. Changing or removing these values can invalidate table metadata or interfere with consistency tracking.Validate the complete property-change list before loading or mutating a table in each supported mixed-catalog implementation. Reject requests containing an internal bookkeeping property before any part can be committed. This covers both direct mixed-catalog registration and unified-catalog delegation across Spark 3.3, 3.4, and 3.5.
Brief change log
table.partition-properties,base.table.max-transaction-id,max-txId,watermark.table, andwatermark.base.How was this patch tested?
TestMixedCatalogPropertyProtection).Using Java 11:
./mvnw spotless:apply checkstyle:checkpassed../mvnw -Pspark-<version> test -pl amoro-format-mixed/amoro-mixed-spark/v<version>/amoro-mixed-spark-<version> -am -Dtest=TestMixedCatalogPropertyProtection -Dsurefire.failIfNoSpecifiedTests=false.This PR addresses the Spark portion of #1121; it does not close the umbrella issue for other interfaces.