Repository navigation
[AMORO-1604][Iceberg] Preserve string event-time metrics in mixed-table writers - #4445
Open
pallavithegod wants to merge 1 commit into
Open
pallavithegod wants to merge 1 commit into
pallavithegod wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #1604.
A string event-time field can inherit Iceberg's default
truncate(16)metrics mode. Timestamp strings such as2026-10-16 12:34:56need more than 16 characters, so a truncated upper bound cannot reliably drive watermark calculation.Default the configured string event-time column to full metrics in
BasicUnkeyedTable.properties(), after catalog properties are merged. Mixed-table writers consume these effective properties for both newly created and existing tables. This covers the table-loading path rather than only internal-catalog creation. Explicit per-column metrics settings remain authoritative, and unrelated columns keep their existing behavior.Brief change log
write.metadata.metrics.column.<event-time-field>=fullwhen the event-time column is a string and has no explicit column override.How was this patch tested?
TestEventTimeMetrics, 12 cases).TestWatermarkGeneratorandTestTableWatermark); 41 selected tests passed in total.Using Java 11 and Maven 3.9.11:
./mvnw spotless:apply checkstyle:checkpassed../mvnw test -pl amoro-format-iceberg -am -Dtest=TestEventTimeMetrics,TestWatermarkGenerator,TestTableWatermark -Dsurefire.failIfNoSpecifiedTests=falsepassed in Linux.