Repository navigation
[AMORO-1503][Common] Log successful Hive partition mutations - #4444
Open
pallavithegod wants to merge 1 commit into
Open
pallavithegod wants to merge 1 commit into
pallavithegod wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #1503.
HMSClientImpldelegates partition additions, drops, and alterations without recording the affected table, partition values, or new location. This makes it difficult to trace mixed-Hive partition changes when diagnosing metadata or data-location problems.Log completed mutations at INFO after the metastore call returns. Failed operations do not emit success messages; a false drop result or a zero-count batch addition is also not reported as a successful change. Existing return values and exception behavior are preserved.
Brief change log
How was this patch tested?
TestHMSPartitionLogging).TestHiveTableTypeUtil); 10 selected tests passed in total.Using Java 11:
./mvnw spotless:apply checkstyle:checkpassed../mvnw test -pl amoro-common -am -Dtest=TestHMSPartitionLogging,TestHiveTableTypeUtil -Dsurefire.failIfNoSpecifiedTests=falsepassed.