refactor(google-maps): move types reference in maps package - #33773
Merged
Conversation
ok7sai
approved these changes
Sep 6, 2026
crisbeto
force-pushed
the
clusterer-refs
branch
3 times, most recently
from
September 6, 2026 11:40
a08fdaf to
f4baace
Compare
crisbeto
changed the title
We need at least one `<reference types="google.maps" preserve="true" />` present in the Google Maps package in order to ensure that the .d.ts we publish has a reference to the types, however internally they need to be stripped. These changes remove the reference that was randomly places in the clusterer types and will update the internal setup to drop the comment.
crisbeto
force-pushed
the
clusterer-refs
branch
from
September 6, 2026 11:47
f4baace to
20315ef
Compare
Member
Author
crisbeto
added a commit
that referenced
this pull request
Sep 7, 2026
We need at least one `<reference types="google.maps" preserve="true" />` present in the Google Maps package in order to ensure that the .d.ts we publish has a reference to the types, however internally they need to be stripped. These changes remove the reference that was randomly places in the clusterer types and will update the internal setup to drop the comment. (cherry picked from commit dd4acb4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need at least one
<reference types="google.maps" preserve="true" />present in the Google Maps package in order to ensure that the .d.ts we publish has a reference to the types, however internally they need to be stripped.These changes remove the reference that was randomly places in the clusterer types and will update the internal setup to drop the comment.