Repository navigation
fix: be less strict about range request responses - #3410
Merged
copybara-service[bot] merged 2 commits intoSep 17, 2026
Merged
copybara-service[bot] merged 2 commits into
copybara-service[bot] merged 2 commits into
Conversation
rohitjoins
force-pushed
the
leo.antunes/be-less-strict-about-range-request-responses
branch
from
September 10, 2026 16:15
5c248db to
fe638d0
Compare
Contributor
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
rohitjoins
force-pushed
the
leo.antunes/be-less-strict-about-range-request-responses
branch
from
September 10, 2026 16:34
fe638d0 to
ed42b75
Compare
The code currently only does manual byte skipping for HTTP responses with a 200 status. There are other valid status codes that may be returned for a non-range response (e.g. 203), so we should be less strict about it.
rohitjoins
force-pushed
the
leo.antunes/be-less-strict-about-range-request-responses
branch
from
September 17, 2026 15:42
ed42b75 to
6b47f35
Compare
costela
deleted the
leo.antunes/be-less-strict-about-range-request-responses
branch
September 18, 2026 10:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code currently only does manual byte skipping for HTTP responses with a 200 status. There are other valid status codes that may be returned for a non-range response (e.g. 203), so we should be less strict about it.
This PR is a re-creation of #3404 to ease merging.