Making LavaBeats shader time relative to the STARTED lifecycle state - #434
Open
JuanSMartinez wants to merge 1 commit into
Open
Making LavaBeats shader time relative to the STARTED lifecycle state#434JuanSMartinez wants to merge 1 commit into
JuanSMartinez wants to merge 1 commit into
Conversation
This makes sure that the shader time is always relative to the lifecycle of the app, avoiding the storage of very large numbers over time as the device is left on for a long period of time. The latter makes the effect laggy and janky due to computations with large numbers
JuanSMartinez
requested review from
alabiaga,
ashnohe,
madebymozart and
yrezgui
as code owners
September 9, 2026 20:54
yrezgui
requested changes
Sep 10, 2026
| } else { | ||
| time = frameTime / 1000f - firstTime | ||
| LaunchedEffect(lifecycleOwner) { | ||
| lifecycleOwner.lifecycle.repeatOnLifecycle(Lifecycle.State.STARTED) { |
Contributor
There was a problem hiding this comment.
Why not using RESUMED state instead?
Contributor
Author
There was a problem hiding this comment.
I tried this at first, but because RESUME occurs later, this resulted in a visible pause between the UI rendering and the animation actually starting. It is mostly a visual preference, as the most important part is to let the time reset once the user leaves the app. If RESUME gives us more performance benefits I could do that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making LavaBeats shader time relative to the STARTED lifecycle state
This makes sure that the runtime shader time is always relative to the lifecycle of the app, avoiding the storage of very large numbers over time as the device is left on for a long period of time. The latter makes the effect laggy and janky due to computations with large numbers