Repository navigation
layersvt: Deduplicate DebugMarker object key fields - #52
Open
olehkuznetsov wants to merge 1 commit into
Open
olehkuznetsov wants to merge 1 commit into
olehkuznetsov wants to merge 1 commit into
Conversation
DebugObjectName stored vk_device, object_type, and handle alongside the object name even though the map key already held the same three fields. Move those fields into a hashed DebugObjectKey struct and store names in std::unordered_map<DebugObjectKey, std::string>, and use a colliding handle across devices in PreDestroyDeviceCleanupTest to cover per-device cleanup on collision. Bug: Test: DebugMarkerTests#PreDestroyDeviceCleanupTest Change-Id: Iec04eb396077047c0be7df0e908041846a6a6964
olehkuznetsov
force-pushed
the
pr-debugmarker-dedup-key
branch
from
October 28, 2026 17:23
a179c60 to
ad5e123
Compare
olehkuznetsov
changed the base branch from
pr-debugmarker-remove-on-destroy
to
main
October 28, 2026 17:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #50 (addresses review feedback from #46):
DebugObjectNamewithDebugObjectKey(vk_device,object_type,handle) andDebugObjectKey::Hash, storing object names instd::unordered_map<DebugObjectKey, std::string, DebugObjectKey::Hash>instead of duplicating the three key fields in both the map key and value struct.0x1111) acrossdev1anddev2inDebugMarkerTests.PreDestroyDeviceCleanupTestto verify per-device cleanup when handles collide across devices.