Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlformat --comma_first Falsecurrently enables comma-first formatting: argparse callsbool('False'), which is true. The same problem affects--compact; evenxxxis silently accepted as true.Keep the existing value-taking syntax and false defaults, but parse
true/falsecase-insensitively and1/0explicitly. Reject other values with an argparse error. The help text now lists the accepted values, and the changelog records the behavior change. No formatter API or formatting algorithm changes.Closes #638.
Validation
uv run --frozen --group dev --python <version> pytest tests/ -q.python -m sqlparsesubprocess output for both options.uv run --frozen --group dev ruff check sqlparse/andgit diff --checkpass.Checklist
pytest)ruff)AI disclosure: Hermes Agent assisted with investigation, implementation, tests and this description under the submitting account owner's authorization. No independent human review is claimed.