Fix nested commas in column definition example - #902
Open
RamiNoodle733 wants to merge 1 commit into
Open
RamiNoodle733 wants to merge 1 commit into
RamiNoodle733 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #731.
extract_definitions()tracks nested parenthesis depth, but currently splits on every comma regardless of that depth and also drops nested opening parentheses. As a result, types such asdecimal(30, 8)are incorrectly treated as two column definitions.This makes commas delimit definitions only at the outer column-list level and preserves nested parentheses in the collected definition. The example SQL now includes
decimal(30, 8)so the reported case is exercised directly.Validation: I reviewed the focused branch diff against current upstream
master. I attempted a local executable check, but this automation runtime does not havesqlparseinstalled, so no local test result is claimed.AI assistance was used to inspect the issue and implementation and prepare the focused fix.