Fix disconnect in InBandConnectionManager for remote case. - #290
Merged
Merged
Conversation
…ent.close() is called. Before the super().disconnect() would occur which would then result in self.connection be set to None and client.close() would never be called
alexandraBara
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix disconnect in InBandConnectionManager so that self.connection.clint.close() is called. Before the super().disconnect() would occur which would then set in self.connection to None then after that client.close() would never be called since it only runes when the type is RemoteShell but by that point it will be None.
Test plan
pytest test/unitpytest test/functional(if applicable)pre-commit run --all-filesChecklist